Assigned
Status Update
No update yet.
Comments
ap...@google.com
Project: src
Branch: main
Author: Harald Alvestrand <
Link:
Extend FindMatchingCodec to support multi-codec RED
Expand for full commit details
Extend FindMatchingCodec to support multi-codec RED
This was exercised by a test, but multi-codec RED is not currently
generated by WebRTC.
RED spec allows it, so failing in comparator seems wrong.
This was one of the cases where the referenced bug was triggered,
but not the only one.
Bug: webrtc:384756621
Change-Id: I28c101aa34a62083b72b5f7fc12d25fc637db209
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/372060
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43607}
Files:
- M
media/base/codec_comparators.cc - M
media/base/codec_comparators_unittest.cc
Hash: 9f827f51f846ac4250078b66249dddfb179db474
Date: Thu Dec 19 06:43:33 2024
Description
While developing media/base/codec_list.cc, tests were discovered that injected a codec multiple times in the codec list.
This is either an error in the test, or accomodation of some real behavior. Suggestion: Fix the test, enable the test and see if anything else reacts to it.